Skip to content

Added Eviction Policy Property for VirtualMachineScaleSetVMProfile for version 2017-12-01#2836

Merged
dsgouda merged 2 commits intoAzure:masterfrom
mahajanudit-microsoft-zz:master
Apr 9, 2018
Merged

Added Eviction Policy Property for VirtualMachineScaleSetVMProfile for version 2017-12-01#2836
dsgouda merged 2 commits intoAzure:masterfrom
mahajanudit-microsoft-zz:master

Conversation

@mahajanudit-microsoft-zz
Copy link
Copy Markdown
Contributor

@mahajanudit-microsoft-zz mahajanudit-microsoft-zz commented Apr 8, 2018 •
edited
Loading

EvictionPolicy can take 2 possible values: Deallocate, Delete
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from dsgouda April 8, 2018 20:42
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 8, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

This was referenced Apr 8, 2018
Merged
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 8, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#2

@AutorestCI AutorestCI mentioned this pull request Apr 8, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 8, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2276

@AutorestCI AutorestCI mentioned this pull request Apr 8, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 8, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1532

@mahajanudit-microsoft-zz
Copy link
Copy Markdown
Contributor Author

mahajanudit-microsoft-zz commented Apr 9, 2018

We plan to have this for Microsoft Build, happening in May first week. Please review this on priority.
Thanks.

dsgouda
dsgouda reviewed Apr 9, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the minor comment

specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json Outdated
],
"x-ms-enum": {
"name": "VirtualMachineEvictionPolicyTypes",
"modelAsString": false
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking modelAsString as false can cause breaking changes if new enum types are added. Please reconsider this.

Copy link
Copy Markdown
Contributor Author

@mahajanudit-microsoft-zz mahajanudit-microsoft-zz Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change it to true then

Copy link
Copy Markdown
Contributor Author

@mahajanudit-microsoft-zz mahajanudit-microsoft-zz Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dsgouda
dsgouda approved these changes Apr 9, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 120ba46 into Azure:master Apr 9, 2018
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Apr 12, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

1 similar comment
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Apr 12, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mahajanudit-microsoft-zz @AutorestCI @azuresdkciprbot @dsgouda @mahajanudit-microsoft